attachextract: don't extract text from zero-byte attachments - #6311
Open
brong wants to merge 1 commit into
Open
Conversation
An attachment whose decoded content is empty has nothing to extract, but
we sent it to the extractor anyway, which rejected it and left an
IOERROR in the log for every such body part:
IOERROR index: can't extract attachment
da39a3ee5e6b4b0d3255bfef95601890afd80709 (APPLICATION/PDF):
Item does not exist
Bail out early when the part's content guid is the SHA1 of zero bytes,
before any cache lookup or HTTP request. Matching on the guid rather
than the raw data length also catches encoded parts, since the content
guid hashes the decoded content.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attachment whose decoded content is empty has nothing to extract, but we sent it to the extractor anyway, which rejected it and left an IOERROR in the log for every such body part:
IOERROR index: can't extract attachment
da39a3ee5e6b4b0d3255bfef95601890afd80709 (APPLICATION/PDF):
Item does not exist
Bail out early when the part's content guid is the SHA1 of zero bytes, before any cache lookup or HTTP request. Matching on the guid rather than the raw data length also catches encoded parts, since the content guid hashes the decoded content.