Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| // capacity_10mAh = Wh * 1000 / dV (because V = dV/10, and 10mAh units = Ah*100) | ||
| const uint16_t v_dV = datalayer.battery.status.voltage_dV; | ||
|
|
||
| uint32_t full_10mAh = (uint32_t)((uint64_t)datalayer.battery.info.total_capacity_Wh * 1000ULL / v_dV); |
There was a problem hiding this comment.
if v_dV would be 0, division would crash the CPU
| // EMUS provides the actual series cell count in datalayer.battery.info.number_of_cells (e.g. 119). | ||
| // Use that when it is sane. Keep the hard-coded values as a fallback for integrations that do not populate | ||
| // number_of_cells (e.g. some Pylon paths set it to a placeholder value). | ||
| uint16_t total_cells = TOTAL_NUMBER_OF_CELLS; |
There was a problem hiding this comment.
These Growatt-HV-CAN changes look great! Could they be added in as a separate PR?
| @@ -0,0 +1,267 @@ | |||
| #include "EMUS-BMS.h" | |||
There was a problem hiding this comment.
This whole EMUS-BMS seems to be 80% PYLON-BATTERY.cpp
Since we are limited on memory, we should instead use Pylon-Battery, and add the separate Emus CAN IDs there in the CAN handler.
We can also add a "250kbps ✅ " option to the Pylon battery, to gain even more compatibility with more batteries.
|
Ok, keeping it compact is a good point. |
|
Nice work! Feel free to open a new PR, or update this one! |
2 participants
This adds integration for Emus G1 BMS, www.emusbms.com
Emus works with the pylon integration for the basic stuff but I have made it's own so cellmonitoring and calculation of capacity from the BMS
Also so further implementation of wanted data, error handling and such doesn't interfer with the pylon integration.
It has been running for couple of days during charge and discharge on my system with Growatt SPH inverter and the emus G1 BMS installed on a 1 string 119 cell LFP diy batterypack.