Skip to content

Conversation

@ludviggunne
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator

Should this be behind a flag? Always parsing for something very niche (and premium only?) seems undesired.

@ludviggunne
Copy link
Collaborator Author

Should this be behind a flag? Always parsing for something very niche (and premium only?) seems undesired.

I think that would be good.

@ludviggunne ludviggunne force-pushed the 14367 branch 2 times, most recently from 565b38a to d27f25b Compare January 11, 2026 18:19
@firewave
Copy link
Collaborator

Should this be behind a flag? Always parsing for something very niche (and premium only?) seems undesired.

I think that would be good.

Since it is specific to certain MISRA rules it should only be active if those rules are active.

@ludviggunne ludviggunne force-pushed the 14367 branch 2 times, most recently from 73a5159 to da0456b Compare January 11, 2026 18:41
@sonarqubecloud
Copy link

class CPPCHECKLIB Parser {
public:
Parser() = delete;
explicit Parser(const Settings &settings) : mSettings(settings) {}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the constructor could look at the settings and check if any misra rules are enabled. If no misra rules are enabled it would make sense if collect and parse will not do anything.

@danmar
Copy link
Owner

danmar commented Jan 12, 2026

Should this be behind a flag? Always parsing for something very niche (and premium only?) seems undesired.

I agree it's niche use case. Especially for open source projects.

imho.. if --premium=misra-c-2012 --inline-suppr or --addon=misra.json --inline-suppr is used then I suggest that the polyspace comments are handled.

If misra checkers are not enabled then it's redundant to handle the polyspace comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants