Add ViewComponent render tracking to ViewTracker#641
Open
dkniffin wants to merge 1 commit intodanmayer:mainfrom
Open
Add ViewComponent render tracking to ViewTracker#641dkniffin wants to merge 1 commit intodanmayer:mainfrom
dkniffin wants to merge 1 commit intodanmayer:mainfrom
Conversation
Subscribe to render.view_component notifications in ViewTracker#railtie! so that ViewComponent template renders are tracked alongside standard Rails view renders. The ViewComponent payload uses view_identifier (not identifier) for the template path, so the subscription maps it accordingly. Requires ViewComponent >= 4.6.0 (which added view_identifier to the payload) and config.view_component.instrumentation_enabled = true in the host app. Also updated the tests and docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup on the conversation on #591. The solution is now possible, since ViewComponent/view_component#2572 was merged
Subscribe to render.view_component notifications in ViewTracker#railtie! so that ViewComponent template renders are tracked alongside standard Rails view renders. The ViewComponent payload uses view_identifier (not identifier) for the template path, so the subscription maps it accordingly.
Requires ViewComponent >= 4.6.0 (which added view_identifier to the payload) and config.view_component.instrumentation_enabled = true in the host app.
Also updated the tests and docs.