feat: Added support for MySQL. - #1567
Conversation
|
|
||
| func ListSQL(ctx context.Context, db *sql.DB, table string, opts ListOptions) ([]string, error) { | ||
| query := fmt.Sprintf(`SELECT key FROM "%s" WHERE key LIKE ?;`, table) | ||
| query := fmt.Sprintf("SELECT `id` FROM `%s` WHERE `id` LIKE ?;", table) |
There was a problem hiding this comment.
It is very likely that this line will break other state store. I just modify this based on what I am seeing from MySQL database that I'm currently seeing.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
keep alive |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
keep alive |
|
Hey @johansja - thx for the PR 🎉 - mind resolving the conflicts? |
|
This is now fixed in master |
4 participants
Description
Support MySQL state store in
dapr workflow listIssue reference
#1568
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: