fix: update cockroachdb image from v21.2.3 to v23.2.29#4272
Open
nelson-parente wants to merge 4 commits intodapr:mainfrom
Open
fix: update cockroachdb image from v21.2.3 to v23.2.29#4272nelson-parente wants to merge 4 commits intodapr:mainfrom
nelson-parente wants to merge 4 commits intodapr:mainfrom
Conversation
The cockroachdb/cockroach:v21.2.3 image has been removed from Docker Hub (v21.2 is EOL), breaking both certification and conformance tests on every scheduled run. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
JoshVanL
previously approved these changes
Mar 11, 2026
cicoyle
previously approved these changes
Mar 11, 2026
CockroachDB v23.2 defaults to requiring TLS. The pgx driver attempts a TLS handshake which gets reset by the insecure-mode server. Adding sslmode=disable to all three connection strings fixes the connection. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
CockroachDB v23.x changed TLS defaults — the pgx driver now attempts TLS even against an --insecure server, causing connection reset errors. Add sslmode=disable to all 3 hardcoded connection strings in the certification test that were missed in the previous commit. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
CockroachDB v23.x takes longer to initialize than v21.x. The TCP port opens before the SQL layer is ready, causing "connection reset by peer" errors. Add a healthcheck using `cockroach sql` and make the init container wait for CockroachDB to be healthy before creating the dapr_test database. Also removes deprecated `version` key from docker-compose files. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cockroachdb/cockroach:v21.2.3Docker image has been removed from Docker Hub (v21.2 went EOL), causingstate.cockroachdb.v1certification and conformance tests to fail on every scheduled run withmanifest unknownv23.2.29(latest v23.2 LTS patch)Files changed
.github/infrastructure/docker-compose-cockroachdb.yml— conformance teststests/certification/state/cockroachdb/v1/docker-compose.yml— certification testsTest plan
state.cockroachdb.v1passes with new imagestate.cockroachdb.v1passes with new image