Add support for custom tool metrics, implement some for analyzer tools#423
Merged
Add support for custom tool metrics, implement some for analyzer tools#423
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
kenzieschmoll
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that analysis server starts up lazily, we want to capture how much of any given call went towards that initialization versus actual work in the tool call. This also will capture how much extra time is added in order to apply quick fixes.
Details:
withAnalysisServercallbackcustomMetricsextension onCallToolResultwhich uses an expando to store additional analytics information for a given tool call.CallToolMetricsto merge this extra information into the analytics data (flat merge).