Defer deletes until build completes#4868
Draft
davidmorgan wants to merge 1 commit intodart-lang:masterfrom
Draft
Defer deletes until build completes#4868davidmorgan wants to merge 1 commit intodart-lang:masterfrom
davidmorgan wants to merge 1 commit intodart-lang:masterfrom
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
defer-deletes
branch
from
6ee121e to
f4e0335
Compare
davidmorgan
force-pushed
the
defer-deletes
branch
from
f4e0335 to
4a94ffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4018
Create the filesystem cache in build_plan instead of in build_series, so that deletes on startup go to the cache and are flushed at the end of the build.
Allow writes/deletes and invalidates without flush in the cache: writes/deletes take precedence over what's on disk.