build: 💥 update to secp256k1 v2.1.0 w/ breaking changes#39
Open
build: 💥 update to secp256k1 v2.1.0 w/ breaking changes#39
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@dashincubator/secp256k1@1.7.1-5, npm/dashkeys@1.1.3, npm/mocha-lcov-reporter@0.0.1, npm/mocha@10.2.0 |
jojobyte
force-pushed
the
ref-secp256k1-2.1.0-compat
branch
2 times, most recently
from
2144c90 to
d11be84
Compare
jojobyte
force-pushed
the
ref-secp256k1-2.1.0-compat
branch
from
d11be84 to
a201184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per paulmillr/noble-secp256k1#upgrading,
sign&verifyhad their defaults renamed, andsignis now sync and requireshmacSha256Syncto be defined, which may require additional repositories, however using theasyncversion does not.Due to that
test/hdkey.test.jswas updated to use theSecp256k1.signAsync, however the returned Signature no longer matched the rest of what the test was looking for, so it was modified further to addtoCompactRawBytes()and therSizeIndexandoffsetswere adjusted to make this work.