Skip to content

Conversation

@vijaydasmp
Copy link

backport

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@vijaydasmp vijaydasmp force-pushed the Jan_2026_6 branch 3 times, most recently from 66b11f8 to c027286 Compare January 7, 2026 02:21
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#28815, 28578, 28931, 28933, 28952 backport: Merge bitcoin/bitcoin#28815, 28931 Jan 7, 2026
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#28815, 28931 backport: Merge bitcoin/bitcoin#28815, 28931, 28009 Jan 10, 2026
@github-actions
Copy link

This pull request has conflicts, please rebase.

@github-actions
Copy link

This pull request has conflicts, please rebase.

fabb504 fuzz: Avoid timeout and bloat in fuzz targets (MarcoFalke)

Pull request description:

  If the fuzz input contains invalid data *in a loop*, abort early. This will teach the fuzz engine to look for useful data and avoids bloating the fuzz input folder with useless (repeated) data.

ACKs for top commit:
  dergoegge:
    utACK fabb504
  brunoerg:
    crACK fabb504

Tree-SHA512: 26da100d7558ae6fdd5292fb146d8858b2af8f78c546ca2509b9d27b33a33e9462ecb6035de142f9f36dd5de32f8cbad099d6c7a697902d23e1bb621cd27dc88
faf1fb2 Fix IWYU for the script_flags fuzz target (MarcoFalke)
fa71285 fuzz: Limit fuzz buffer size in script_flags target (MarcoFalke)
fa6b87b fuzz: CDataStream -> DataStream in script_flags (MarcoFalke)

Pull request description:

  Most fuzz targets have an upper limit on the buffer size to avoid excessive runtime. Do the same for `script_flags` to avoid timeouts such as bitcoin#28812 (comment)

  Also, fix iwyu. Also, remove legacy `CDataStream`.

ACKs for top commit:
  dergoegge:
    ACK faf1fb2
  brunoerg:
    utACK faf1fb2

Tree-SHA512: 9301917b353f7409e448b6fd3635de19330856e0742431db5ef04e62873501b5b4cd6cb78ad81ada2747fa2bdae033115b5951d10489dd5d0d320426c8b96bee
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#28815, 28931, 28009 backport: Merge bitcoin/bitcoin#28815, 28931, 28009, 19909, 26679 Jan 28, 2026
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#28815, 28931, 28009, 19909, 26679 backport: Merge bitcoin/bitcoin#28815, 28931, 28009, 26679 Jan 28, 2026
… than tip

3784009 wallet: Skip rescanning if wallet is more recent than tip (Andrew Chow)

Pull request description:

  If a wallet has key birthdates that are more recent than the currrent chain tip, or a bestblock height higher than the current tip, we should not attempt to rescan as there is nothing to scan for.

  Fixes bitcoin#26655

ACKs for top commit:
  ishaanam:
    re-utACK 3784009
  w0xlt:
    utACK bitcoin@3784009
  furszy:
    Code review ACK 3784009

Tree-SHA512: f0d90b62940d97d50f21e1e01fa6dcb54409fad819cea4283612825c4d93d733df323cd92787fed43956b0a8e386a5bf88218f1f5749c913398667a5c8f54470
@vijaydasmp vijaydasmp marked this pull request as ready for review January 31, 2026 14:48
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#28815, 28931, 28009, 26679 backport: Merge bitcoin/bitcoin#28815, 28931, 26679 Jan 31, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

Walkthrough

This pull request introduces changes across multiple areas: header management in interpreter.h (adjusting includes and forward declarations), enhancements to fuzz testing infrastructure by introducing a good_data flag mechanism to gracefully handle invalid input data across multiple fuzz test files, documentation updates to the LIMITED_WHILE macro, refactoring of serialization handling in script_flags.cpp, and modifications to wallet rescanning logic in CWallet::AttachChain to unconditionally infer wallet birth time and adjust rescanning windows based on chain state.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the PR as a backport of three specific Bitcoin issues (28815, 28931, 26679) and matches the commit messages summarizing those changes.
Description check ✅ Passed While minimal, the description 'backport' directly relates to the changeset which consists entirely of backported Bitcoin improvements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants