test: improve token state transition tests with SDK 3.0 validation

[thephez]

Token State Transition Test Improvements

Updates token state transition tests to work properly with SDK 3.0, fixing field name mismatches and adding proper response validation. Also expands emergency actions test and adds token config updates back in.

Changes

• Fix token direct purchase SDK field mapping - Changed identityId to buyerId and totalAgreedPrice to maxTotalCost to match SDK 3.0 interface
• Expand token emergency action test - New test with pause/resume steps using test.step() pattern
• Add token config update test - Added test (currently skipped pending SDK support) with validation
• Update token claim test - Gracefully skip when no rewards are available instead of failing
• Relocate and re-enable destroy frozen tokens test - Fixed test ordering for proper execution
• Add response validation - validateTokenDirectPurchaseResult and validateTokenEmergencyActionResult now properly validate SDK 3.0 response format

Summary by CodeRabbit

• API Changes
  • Updated token direct purchase parameter names: identityId → buyerId and totalAgreedPrice → maxTotalCost for enhanced consistency and clarity

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update SDK field names in the direct purchase operation, add test data for token configuration updates, and significantly expand the test suite with new validation helpers, state transition variants, and error retry mechanisms.

Changes

Cohort / File(s)	Summary
SDK API Updates public/app.js	Renamed tokenDirectPurchase payload fields: identityId → buyerId and totalAgreedPrice → maxTotalCost in the callEvo function.
Test Data tests/e2e/fixtures/test-data.js	Added tokenConfigUpdate test data entry with configuration parameters (identityId, contractId, tokenPosition, configItemType, configValue, publicNote, description).
Test Suite Enhancements tests/e2e/transitions/state-transitions.spec.js	Introduced validation helpers (validateTokenConfigUpdateResult, validateTokenEmergencyActionResult), executeStateTransitionWithCustomParams helper, retry mechanism for transient errors, renamed test flows (tokenUnfreeze → tokenDestroyFrozen), activated previously skipped tests, and expanded state transition coverage with new paths for emergency actions and config updates.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title "test: update token tests" is vague and overly generic, using non-descriptive language that doesn't convey the specific nature of the changes.	Consider a more specific title that highlights the main changes, such as "test: update token test flows and fix SDK field mappings" or "test: add token emergency action tests and fix direct purchase mapping".

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch v3-update-adjustments-sts-token

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thephez]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.