Skip to content

[Exporter] Add support for serverless egress controls - #5238

Merged
alexott merged 5 commits into
mainfrom
exporter/seg-support
Jan 20, 2026
Merged

[Exporter] Add support for serverless egress controls#5238
alexott merged 5 commits into
mainfrom
exporter/seg-support

Conversation

@alexott

@alexott alexott commented Nov 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

This includes support for:

  • databricks_account_network_policy
  • databricks_workspace_network_option

Also introduced NameUnified for correct generation of TF resource names

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

@alexott
[Exporter] Add support for serverless egress controls
608fb41 
This includes support for:

- `databricks_account_network_policy`
- `databricks_workspace_network_option`
@alexott
alexott requested review from a team as code owners November 30, 2025 10:06
@alexott
alexott requested review from renaudhartert-db and removed request for a team November 30, 2025 10:06
@alexott alexott added exporter TF configuration generator ai-assisted labels Dec 2, 2025
rauchy
rauchy requested changes Dec 3, 2025
View reviewed changes

@rauchy rauchy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some test coverage?

Comment thread exporter/impl_serverless.go
@alexott

alexott commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Regarding tests, the current test framework doesn't work for account-level resources. It requires a completely new implementation

@alexott
alexott temporarily deployed to test-trigger-is December 3, 2025 13:19 — with GitHub Actions Inactive
@alexott
alexott temporarily deployed to test-trigger-is December 3, 2025 13:19 — with GitHub Actions Inactive
@alexott
alexott requested a review from rauchy December 3, 2025 14:36
@alexott
alexott temporarily deployed to test-trigger-is December 3, 2025 14:37 — with GitHub Actions Inactive
@alexott
alexott temporarily deployed to test-trigger-is December 3, 2025 14:37 — with GitHub Actions Inactive
@alexott
alexott temporarily deployed to test-trigger-is December 4, 2025 12:19 — with GitHub Actions Inactive
@alexott
alexott temporarily deployed to test-trigger-is December 4, 2025 12:20 — with GitHub Actions Inactive
@alexott
alexott temporarily deployed to test-trigger-is December 8, 2025 15:27 — with GitHub Actions Inactive
@alexott
alexott temporarily deployed to test-trigger-is December 8, 2025 15:28 — with GitHub Actions Inactive
@alexott
alexott requested a review from tanmay-db December 8, 2025 15:35
@alexott

alexott commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

@rauchy I've added tests, and then #5262 adds even more

@alexott
alexott force-pushed the exporter/seg-support branch from b74c879 to cba4d87 Compare December 20, 2025 17:46
@alexott
alexott temporarily deployed to test-trigger-is January 12, 2026 16:53 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 5238
  • Commit SHA: cde7a9e859a4ea73812aabe92511ee0c28636746

Checks will be approved automatically on success.

@alexott
alexott temporarily deployed to test-trigger-is January 12, 2026 16:54 — with GitHub Actions Inactive
@alexott
alexott enabled auto-merge January 20, 2026 10:04
rauchy
rauchy approved these changes Jan 20, 2026
View reviewed changes

@rauchy rauchy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexott
alexott added this pull request to the merge queue Jan 20, 2026
Merged via the queue into main with commit 56e5bf5 Jan 20, 2026
12 checks passed
@alexott
alexott deleted the exporter/seg-support branch January 20, 2026 10:15
deco-sdk-tagging Bot added a commit that referenced this pull request Jan 22, 2026
@deco-sdk-tagging
[Release] Release v1.104.0
4e1300c 
## Release v1.104.0

### New Features and Improvements
* Added resources and data sources for `databricks_account_user_setting_v2` and `databricks_default_warehouse_override` ([#5329](#5329)).

### Bug Fixes

* Fix importing of the `databricks_share` ([#5311](#5311))
* Fix `databricks_dashboard` resource to include `dataset_catalog` and `dataset_schema` when retrying creation after parent folder creation ([#5327](#5327))

### Exporter

* Rewrite cloud-specific attributes and node types in cluster policy definitions when using `-targetCloud` flag ([#5297](#5297)).
* Added support for `databricks_account_network_policy` and `databricks_workspace_network_option` resources ([#5238](#5238)).
* Rewrite exporting of `databricks_share` to plugin framework ([#5328](#5328))

### Internal Changes
* Add support for unified host, migrate IsAccountClient to HostType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rauchy rauchy rauchy approved these changes
@840 840 840 approved these changes
@renaudhartert-db renaudhartert-db Awaiting requested review from renaudhartert-db renaudhartert-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers
@tanmay-db tanmay-db Awaiting requested review from tanmay-db

Assignees

No one assigned

Labels

ai-assisted exporter TF configuration generator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexott @rauchy @840