fix(duckdb): use explicit contract schema columns for CSV/Parquet reads (#1065)#1183
Closed
barry0451 wants to merge 1 commit into
Closed
fix(duckdb): use explicit contract schema columns for CSV/Parquet reads (#1065)#1183barry0451 wants to merge 1 commit into
barry0451 wants to merge 1 commit into
Conversation
…ds (datacontract#1065) Previously the INTERSECT query selected only columns present in BOTH contract and data, so missing contract columns were silently ignored — field_is_present always passed. Now we SELECT explicitly the contract schema columns by name, so missing data columns become NULL and field_is_present can properly catch them.
Collaborator
|
Closing in favour of #1163. Please avoid creating PRs if another one already exists for this issue, except when it is stale for a longer time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1065 —
field_is_presentcheck always passes for CSV/Parquet files because the current implementation compares row counts instead of checking actual column overlap. Uses explicit SELECT of contract schema columns so missing data columns = NULL, allowingfield_is_presentto catch them.Changes
create_view_with_schema_unionindatacontract/engines/soda/connections/duckdb_connection.pyTesting