Fixed import sql ignoring multiple tables in a ddl file#1201
Open
joe-albert wants to merge 10 commits into
Open
Fixed import sql ignoring multiple tables in a ddl file#1201joe-albert wants to merge 10 commits into
joe-albert wants to merge 10 commits into
Conversation
in a ddl - Adds in support for additional datatypes from mysql
entries in ODCS file generated
table level rather than as part of the column definition - Fix tests
defined at the table level rather than as part of the column definition.
Collaborator
|
The changes LGTM! Can you add tests or extend an existing test to cover the bugs you described (multiple tables & composite keys)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue I noticed where when a sql ddl file had multiple tables defined the import functionality would only convert the first one to ODCS and ignore the rest.
Also, a few mysql types were not handled so I added handling for those.
Edit: sorry made a few other changes to accommodate primary keys defined at the table level.
uv run pytest) [I ran relevant tests and they passed-- I do not have docker setup locally so did not run the full suite, also did not see any documentation on this part of the testing?]uv run ruff check --fix && uv run ruff format)This is a test sql ddl I used where only the first table was processed: