Auto-create editor delegation on DataPass validation webhook#246
Merged
Un3x merged 5 commits intoJul 7, 2026
Merged
Conversation
Distinguishes manual delegations from upcoming DataPass auto-creation.
A non-delegable editor alerts Sentry without failing the context, so the webhook keeps flowing and DataPass does not retry.
Inserted in the V1 organizer chains right after token creation: V2 webhooks flow through them via AdaptV2ToV1, and V1 webhooks no-op since no editor form_uid matches their demarches.
Reuse MonitoringService for the Sentry warning and move the form_uids lookup onto Editor where the column lives.
Un3x
requested review from
Samuelfaure and
skelz0r
and removed request for
skelz0r
skelz0r
requested changes
Jul 6, 2026
Review feedback: the delegation formalizes an already-existing reality, so the webhook records it unconditionally; the boolean will gate editor token usage instead. Also move the interactor under DatapassWebhook since it is webhook-specific.
Un3x
deleted the
feature/api-6622-t2-creation-automatique-de-delegation-au-webhook-datapass
branch
Member
|
Je note ça là pour trace : du coup maintenant les usagers auront sur la vue d'une habilitation les délégations, et il me semble que c'est "révocable" ici, même si ça n'a pas vraiment de sens. J'ai une PR avec une itération en cours sur l'ensemble de la vue (qui certes traine) qui clarifie un peu plus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataPass approve/validate webhooks on an editor form now auto-create the
EditorDelegation(idempotent,created_via: datapass_auto).created_viacolumn + enum onEditorDelegationEditorDelegation::AutoCreateinserted afterCreateOrProlongTokenin both webhook organizer chains; a non-delegable editor alerts Sentry without failing the webhookCloses API-6622 → https://linear.app/pole-api/issue/API-6622/t2-creation-automatique-de-delegation-au-webhook-datapass
🤖 Generated with Claude Code