Reset blacklisted_at when regenerating a banned token#248
Merged
Conversation
When banning a token with regeneration, the Ban organizer runs BanToken (which sets blacklisted_at on the original token) then RegenerateToken, which builds the replacement via token.dup. dup copies every attribute including the freshly-set blacklisted_at, so the regenerated token was born banned and would expire at the exact same moment as the token it was meant to replace, defeating the purpose of regeneration. Explicitly clear blacklisted_at on the duplicate so the new token is actually active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When banning a token with regeneration, the Ban organizer runs BanToken (which sets blacklisted_at on the original token) then RegenerateToken, which builds the replacement via token.dup. dup copies every attribute including the freshly-set blacklisted_at, so the regenerated token was born banned and would expire at the exact same moment as the token it was meant to replace, defeating the purpose of regeneration.
Explicitly clear blacklisted_at on the duplicate so the new token is actually active.