Fix potential crash while exiting console version of K95#528
Draft
Fix potential crash while exiting console version of K95#528
Conversation
While K95 is exiting, Windows can report a buffer size larger than what K95 supports. As TermScrnUpd only allocates a buffer large enough for the maximum terminal dimensions supported by K95, this larger size reported by Windows can cause TermScrnUpd to overrun its buffer. This bug is reproduceable on versions of K95 going back to 1.1.17, though its possible that the console environment changes introduced with Windows 10 v1809 are what makes it possible to trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While K95 is exiting, Windows can report a buffer size larger than what K95 supports. As TermScrnUpd only allocates a buffer large enough for the maximum terminal dimensions supported by K95, this larger size reported by Windows can cause TermScrnUpd to overrun its buffer.
This bug is reproduceable on versions of K95 going back to 1.1.17, though its possible that the console environment changes introduced with Windows 10 v1809 are what makes it possible to trigger.