Draft
Conversation
The TermScrnUpd thread is never stopped during exit. This means it never cleans up its resources (not that it really matters), and its still running when any mutexes, semaphores, and thread local storage it depends on is cleaned up. If there is/was a reason why this thread should be left running all the way to process termination it is not obvious to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TermScrnUpd thread is never stopped during exit. This means it never cleans up its resources (not that it really matters), and its still running when any mutexes, semaphores, and thread local storage it depends on is cleaned up.
If there is/was a reason why this thread should be left running all the way to process termination it is not obvious to me. So make it stop once its no longer needed.