fix(api): remove early return in resize sandbox job success handler#4430
Open
brunogrbavac wants to merge 1 commit intomainfrom
Open
fix(api): remove early return in resize sandbox job success handler#4430brunogrbavac wants to merge 1 commit intomainfrom
brunogrbavac wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Bruno Grbavac <bruno.grbavac@outlook.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Removes an unintended early return in the RESIZE_SANDBOX job completion handler so that, after updating organization quota usage, the handler continues to run the remaining post-success logic (notably persisting the sandbox’s updated resources/state).
Changes:
- Removed the premature
returnafter applying resize quota usage changes on successful resize job completion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
View your CI Pipeline Execution ↗ for commit fd97188
☁️ Nx Cloud last updated this comment at |
Tpuljak
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RESIZE_SANDBOX success handler had an early
returnafter callingupdateQuotaUsagewith the new CPU/memory/disk deltas. This caused any logic after the quota update to be skipped when a resize job completed successfully. Thereturnwas likely left over from a refactor — theelse if (FAILED)branch below handles failures correctly, but the success path was bailing out prematurely. Removing it allows the success handler to fall through and complete the full post-resize flow.Documentation