Update workflows to use pipenv-setup@v4.4.0 with editable flag#1294
Update workflows to use pipenv-setup@v4.4.0 with editable flag#1294fizyk merged 5 commits intodbfixtures:mainfrom
Conversation
Upgraded fizyk/actions-reuse pipenv-setup action from v4.2.1 to v4.4.0 which includes built-in support for editable package installation via the editable flag. Changes: - Updated pipenv-setup to v4.4.0 in dockerised-postgres.yml, oldest-postgres.yml, and single-postgres.yml - Added editable: true parameter to all pipenv-setup steps - Split dockerised-postgres.yml combined pipenv action into separate pipenv-setup and pipenv-run steps Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request refactors pytest-postgresql integration by converting it to an editable self-install in Pipfile, splitting the CI workflow Pipenv action into separate setup and run steps, and removing manual plugin imports and re-registrations from test configuration files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The pipenv-setup@v4.4.0 upgrade and editable: true flag additions have been extracted into a dedicated PR (dbfixtures#1294). Remove those changes from this branch to avoid duplication and conflicts once that PR is merged. Made-with: Cursor
|
We need also a conftest changes (and newsfragment). Additionally, what I found is that if you add entry like that: https://github.com/dbfixtures/pytest-dynamodb/blob/main/Pipfile#L12 You actually don't need the editable true option at all |
Removed the editable flag from workflow files to streamline the setup process. This change ensures that the editable flag is only specified where necessary, specifically in the Pipfile for pytest-postgresql. Changes: - Added pytest-postgresql as an editable dependency in Pipfile - Removed editable: true from dockerised-postgres.yml, oldest-postgres.yml, and single-postgres.yml Made-with: Cursor
What do you want me to do to the conftest? |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@newsfragments/`+pipfile-editable.misc.rst:
- Line 1: Rename the newsfragment file +pipfile-editable.misc.rst to the
required orphan naming pattern so Towncrier validation will pass; change the
filename to either +<hash>.misc.rst (a unique hash) or <issue_number>.misc.rst
if this change is associated with an issue, keeping the .misc.rst suffix (the
fragment content can remain unchanged).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df78e1a7-5dec-4dd5-8878-0b95d89d111d
📒 Files selected for processing (5)
.github/workflows/dockerised-postgres.yml.github/workflows/oldest-postgres.yml.github/workflows/single-postgres.ymlPipfilenewsfragments/+pipfile-editable.misc.rst
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/workflows/oldest-postgres.yml
- .github/workflows/dockerised-postgres.yml
With editable install, and this line: Also, this line for pytester tests: We'll get this error: Once we get this change running and merged, your other PRs won't need to wait for me to trigger CI. At least in theory |
…es.yml conflict keeping split setup/run steps at v4.4.4 Made-with: Cursor
… With pytest-postgresql installed editably via Pipfile, the plugin is auto-registered through entry points. Remove the wildcard import from tests/conftest.py and the makeconftest call from pointed_pytester that caused duplicate plugin registration errors (fizyk requested in PR 1294) Made-with: Cursor
|
@fizyk should be ok now. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Upgrades fizyk/actions-reuse pipenv-setup action from v4.2.1 to v4.4.0 across all workflow files that install the package before running tests. The new version adds built-in support for installing the package in editable mode via the editable flag, removing the need for separate explicit pip install -e . steps.
Changes
This aligns with the pattern established in pytest-mongo and reduces workflow complexity.
Addresses request from PR #1182.
Summary by CodeRabbit
Release Notes