Conversation
updated all composer packages restored STRAPI_URL revised esceptions classes
Stubbs
left a comment
There was a problem hiding this comment.
Looks good to me. The new queryParams means I don't have to re-implement my changes that introduced filters to the collection method.
|
Hi @dbfx, is there any problem accepting this pull request? |
|
@frugan-dev We have forked this package over at BRFCS/laravel-strapi because it looks like this repo is deprecated and we needed Laravel 11 support. Feel free to contribute if you still use Laravel & Strapi. We're not on packagist yet though. |
Hi @Stubbs , If you ask for my contribution, you should have included my changes in this PR in your fork.. |
|
@frugan-dev That's a good idea, are you open to adding myself & @frugan-dev as collaborators on this repo? |
|
The question should be asked to @dbfx |
- add CACHE_DISABLED and CACHE_FOREVER constants - refactor getResponse() method
|
Hi guys, apologies for the delay only saw this now. Have invited you! |
and I missed the invite, which has now expired 🤦 |
DONE
getResponse()$responsereturned byCache::remember()https://stackoverflow.com/a/74783008/3929620$response->throw()Illuminate\Http\Client\RequestExceptionHttp::withToken()instead ofHttp::withHeaders()Http::withQueryParameters()instead ofhttp_build_query()Http::withOptions()andHttp::baseUrl()$typeto$name, as it is more consistent with the field used by Strapi$queryDatato$queryParams, as it is more consistent withHttp::withQueryParameters()$sortKey,$sortOrder,$populate, etc.) in favor of$queryParams, which allows greater control over the API parameters used$queryParamsalso allows you to use pagination by offset values (pagination[start]andpagination[limit]), which previously conflicted with pagination by page values (pagination[page]andpagination[limit]) set directly within the methodcollection()$cacheTimeparameter to override the global value defined inSTRAPI_CACHE_TIMEper-callcollectionCount()method, as the/api/$name/countentrypoint does not seem to exist anymore in Strapi v4 (?), and also thepagination[withCount]parameter exists and it's active by defaultentriesByField()method as it is superfluous, because it is possible to make the same call with thecollection()method (see examples inREADME)STRAPI_FULL_URLSglobally in.envfile$pluckparameter as it is superfluous to the primary functionality of this package: everyone is free to alter the response as they wishconfig('strapi.pagination.limit')from 20 to 25 (default Strapipagination[pageSize])READMEfileTODO
README? this could be included in this section, useful for those who have a local development setup (e.g. mkcert):