Skip to content

Extract runtime and event sink boundary - #184

Closed
parsakhaz wants to merge 2 commits into
paseo-and-morph-inspofrom
phase1-core-runtime-boundary
Closed

Extract runtime and event sink boundary#184
parsakhaz wants to merge 2 commits into
paseo-and-morph-inspofrom
phase1-core-runtime-boundary

Conversation

@parsakhaz

Copy link
Copy Markdown
Member

Summary

  • add daemon-neutral core runtime, event sink, and core service contracts under main/src/core
  • initialize the runtime from Electron bootstrap and route service event delivery through PaneEventSink
  • remove targeted main/src/index.ts runtime-global imports from service-layer PTY/session/panel managers and adjacent service stragglers required by the repo-wide grep gate

Why

This is the first Phase 1 daemon/client boundary slice from tmp/ready-plans/2026-05-14-daemon-client-split.md. It keeps Electron as the active client while moving service runtime access behind an explicit seam that a future local/remote daemon transport can reuse.

Validation

  • pnpm typecheck
  • pnpm lint
  • CI=1 pnpm --filter main test
  • PANE_DIR=/tmp/pane-phase1-smoke-... xvfb-run -a pnpm test:ci:minimal
  • PANE_USE_PTY_HOST=1 PANE_DIR=/tmp/pane-phase1-smoke-ptyhost-... xvfb-run -a pnpm test:ci:minimal

Stacking

@parsakhaz

Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz

Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz
parsakhaz force-pushed the phase1-core-runtime-boundary branch from 0c30557 to b49f814 Compare May 17, 2026 21:13
@parsakhaz

Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz

Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz
parsakhaz force-pushed the phase1-core-runtime-boundary branch from b49f814 to 7a59c51 Compare May 17, 2026 21:21
@parsakhaz

Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz

Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant