Skip to content

feat: daemonize permission approval flow#205

Closed
parsakhaz wants to merge 2 commits into
phase3-remote-http-sse-authfrom
phase3-daemon-permission-broker
Closed

feat: daemonize permission approval flow#205
parsakhaz wants to merge 2 commits into
phase3-remote-http-sse-authfrom
phase3-daemon-permission-broker

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • move permission approval state and request/resolve fanout into a daemon-owned broker instead of BrowserWindow globals
  • route permission:getPending and permission:respond through the shared daemon registry/bridge so local and future remote clients hit the same surface
  • switch the Electron renderer to typed permission lifecycle events plus pending-request reloads, and forward permission events to daemon subscribers

Testing

  • pnpm typecheck
  • pnpm lint
  • CI=1 pnpm --filter main test -- --run
  • PANE_DIR=/tmp/pane-phase3-permission-broker xvfb-run -a pnpm test:ci

Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown
Member Author

@claude review

Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz parsakhaz force-pushed the phase3-remote-http-sse-auth branch from 5773dfd to f391fe3 Compare May 17, 2026 21:13
@parsakhaz parsakhaz force-pushed the phase3-daemon-permission-broker branch from fd67c83 to b969604 Compare May 17, 2026 21:13
@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz parsakhaz force-pushed the phase3-remote-http-sse-auth branch from f391fe3 to aabe811 Compare May 17, 2026 21:21
@parsakhaz parsakhaz force-pushed the phase3-daemon-permission-broker branch from b969604 to a6ffe20 Compare May 17, 2026 21:21
@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant