feat: link hosted cloud workspaces to remote profiles#209
Conversation
|
@codex review |
|
@claude review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
@claude review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 660c66c097
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9ac89d5d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@claude review |
parsakhaz
force-pushed
the
phase4-hosted-cloud-state-contract
branch
from
6297a57 to
28af91a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10603051eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
1060305 to
7884ec5
Compare
|
@codex review |
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7884ec5994
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
7884ec5 to
d01e371
Compare
|
@codex review |
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d01e371dd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@claude review |
parsakhaz
force-pushed
the
phase4-hosted-cloud-state-contract
branch
from
24debe8 to
e10285f
Compare
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
76af9ef to
6e3ded9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76af9ef36b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@claude review |
|
@codex review |
|
@claude review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
parsakhaz
force-pushed
the
phase4-hosted-cloud-state-contract
branch
from
2195052 to
72ae2b7
Compare
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
d58c5ee to
d79e8cf
Compare
|
@codex review |
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d79e8cf410
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!linkedProfile) { | ||
| return 'available'; |
There was a problem hiding this comment.
When cloud.linkedRemoteProfileId is set but the corresponding remote profile has been deleted or failed to load, this returns available, so CloudWidget renders the “Connect Cloud” action even though connectWorkspace() immediately rejects the same state with Hosted cloud workspace linked profile ... does not exist (see the lookup/throw in connectWorkspace). This leaves users with a connect button that cannot succeed after profile cleanup or config drift; report an unlinked/error state or recreate the profile before exposing the action.
Useful? React with 👍 / 👎.
parsakhaz
force-pushed
the
phase4-hosted-cloud-state-contract
branch
from
72ae2b7 to
fe10352
Compare
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
d79e8cf to
93366be
Compare
parsakhaz
force-pushed
the
phase4-hosted-cloud-state-contract
branch
from
fe10352 to
36bf687
Compare
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
93366be to
1c97d0a
Compare
|
@codex review |
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c97d0a5a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <> | ||
| {canManageCloudVmLifecycle && ( | ||
| <button | ||
| onClick={handleStop} |
There was a problem hiding this comment.
When a managed VM is connected through the hosted daemon and also has a noVNC URL, this Stop button calls handleStop/cloud:stop-vm while leaving remoteDaemon.client.mode in remote and the active profile connected. After the VM is powered off, daemon-owned renderer calls such as sessions:get-all are still routed through remotePaneClientController.invoke to the now-dead cloud daemon, so the app remains pointed at the stopped workspace until the user separately switches back to local. Please disconnect the workspace before/inside the stop path for this connected-cloud case.
Useful? React with 👍 / 👎.
parsakhaz
force-pushed
the
phase4-cloud-remote-workspace-link
branch
from
1c97d0a to
42405db
Compare
parsakhaz
force-pushed
the
phase4-hosted-cloud-state-contract
branch
from
36bf687 to
4dc2aa6
Compare
|
@codex review |
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42405db324
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {daemonConnectionUnavailable && !loading && ( | ||
| <> | ||
| <button | ||
| onClick={handleDisconnectWorkspace} |
There was a problem hiding this comment.
When the saved linkedRemoteProfileId no longer exists (for example after the user deletes the remote profile in Settings), CloudVmManager reports remoteConnectionStatus: 'error', so this branch renders only the “Use Local Runtime” action. That action calls disconnectWorkspace(), but because the profile is not active/present it returns the same error state without changing anything, leaving the widget stuck on “Cloud Connection Error” with no way to reconnect or rerun setup from the cloud widget.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
pnpm typecheckpnpm lintCI=1 pnpm --filter main exec vitest runPANE_DIR=/tmp/pane-phase4-task2-cloud-link xvfb-run -a pnpm test:ci