feat(check_previous_channel_release): swap module_source domain with registry input#75
Open
duckhawk wants to merge 2 commits into
Open
feat(check_previous_channel_release): swap module_source domain with registry input#75duckhawk wants to merge 2 commits into
duckhawk wants to merge 2 commits into
Conversation
Promotes the per-repository check_previous_channel_release.sh script
into a reusable composite action so module repositories don't have to
ship and maintain their own copy.
The version parser now handles both single-line (`{"version":"v0.1.14"}`)
and pretty-printed multi-line `version.json` produced by yq (newlines
and indentation around the keys), using a multiline-aware PCRE grep.
…registry input The previous-channel image often lives on a read-only mirror that has a different domain than the registry used to push releases. Swap the domain portion of `module_source` with the `registry` input before calling `crane export`, so callers can pass `vars.PROD_REGISTRY_READ` while keeping `module_source` built from `vars.PROD_REGISTRY`.
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous-channel image often lives on a read-only registry mirror whose domain differs from the registry used to push releases. Today
check_previous_channel_releasecallscrane export "${module_source}/${module_name}/release:${previous_channel}"against the same domain that's baked intomodule_source, which forces callers to align the two.With this change the action swaps the domain portion of
module_sourcewith theregistryinput before exporting the image:So callers can pass
vars.PROD_REGISTRY_READasregistrywhile still keepingmodule_sourcebuilt fromvars.PROD_REGISTRY(which is whatdeploy@v14wants).The
registryinput description is updated to document the behaviour.Follow-up to #73.
Test plan
MODULE_SOURCE=registry.deckhouse.io/deckhouse/ce/modules; REGISTRY=registry-read.deckhouse.io; echo "\${REGISTRY}/\${MODULE_SOURCE#*/}"→registry-read.deckhouse.io/deckhouse/ce/modules.registry: \${{ vars.PROD_REGISTRY_READ }}and trigger a non-alpha-channel deploy as a smoke test once this lands on `v14`.