revert(vd): revert allowing ingress from virtualization namespace to uploader pods#2396
Merged
Merged
Conversation
…uploader pods This reverts commit 67b70fa. The original fix introduced an Ingress rule that allowed traffic only from namespaces labeled with 'module: virtualization'. However, this breaks the e2e DataExport test because the uploader pod is accessed via Ingress controller, which is located in a different namespace (e.g., d8-ingress-nginx) that has 'module: ingress-nginx' label instead. The request flow in the test: 1. Test sends HTTP request to the Ingress URL 2. Request hits the Ingress controller pod (in d8-ingress-nginx namespace) 3. Ingress controller proxies the request to the uploader pod 4. NetworkPolicy blocks this because the source namespace doesn't have 'module: virtualization' label A proper fix would require allowing ingress from ingress controller namespaces or using pod selectors instead of namespace selectors. Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
changed the title
yaroslavborbat
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts the changes introduced in commit 67b70fa which added an Ingress rule to NetworkPolicy for uploader pods.
The original fix added an Ingress rule allowing traffic only from namespaces labeled with
module: virtualization. This was intended to allow the CDI controller to scrape progress metrics from importer pods in isolated namespaces. However, this breaks the e2e DataExport test because the uploader pod is accessed via the Ingress controller, which is located in a different namespace (e.g., d8-ingress-nginx) with labelmodule: ingress-nginx.Why do we need it, and what problem does it solve?
The e2e test
DataExports exports VirtualDisk and VirtualDiskSnapshot, then restores data via uploadfails with the following error:The request flow in the test:
module: ingress-nginxlabel, notmodule: virtualizationThe fix reverts the Ingress rule addition, restoring the previous behavior where only Egress policy was applied.
What is the expected result?
The e2e test
DataExportsshould pass after this revert.Checklist
Changelog entries