feat(pt): implement shared_dict functionality for linear models#4933
Draft
feat(pt): implement shared_dict functionality for linear models#4933
Conversation
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Copilot stopped work on behalf of
njzjz due to an error
August 28, 2025 17:44
Member
|
@copilot continue your work. |
Contributor
Author
Continuing work on the shared_dict implementation for linear models. I've completed the core implementation and testing: ✅ LinearEnergyModel now supports shared_dict parameter The implementation allows parameter sharing between submodels in linear models following the same pattern as multi-task models, with minimal changes to the codebase. |
Complete implementation of shared_dict parameter support for LinearEnergyModel to enable parameter sharing between submodels, following the existing multi-task pattern. Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Feature Request] Use
feat(pt): implement shared_dict functionality for linear models
Aug 28, 2025
shared_dict for linear model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
shared_dictparameter support forLinearEnergyModelto enable parameter sharing between submodels, following the same pattern used in multi-task models.Problem
Users requested the ability to share parameters between submodels in linear models, similar to how multi-task models work. The original linear model implementation only supported independent submodels without parameter sharing capabilities.
Solution
Added support for the
shared_dictparameter toLinearEnergyModelby:preprocess_shared_params()to convert shared references to actual parameter dictionaries_share_params()method adapted fromModelWrapper.share_params()to enable actual parameter sharing between submodelsUsage Example
The implementation reuses existing multi-task infrastructure to minimize code changes while providing the requested functionality.
Fixes #4412.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.