style: enable BreakArrays in clang-format configuration#5179
style: enable BreakArrays in clang-format configuration#5179njzjz wants to merge 1 commit intodeepmodeling:masterfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
There was a problem hiding this comment.
Pull request overview
This PR attempts to add a BreakArrays option to the clang-format configuration file. However, this option is not a valid clang-format configuration parameter and will either be ignored or cause errors.
Changes:
- Adds
BreakArrays: trueto.clang-formatconfiguration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| BasedOnStyle: Google | ||
| BinPackParameters: false | ||
| InsertBraces: true | ||
| BreakArrays: true |
There was a problem hiding this comment.
The option BreakArrays is not a valid clang-format configuration option. This will likely be ignored by clang-format or could cause errors depending on the version being used.
If you're trying to control array formatting, consider using valid options such as:
AlignArrayOfStructures(controls alignment of arrays)BinPackArguments(controls whether function call arguments are bin-packed)ColumnLimit(affects when arrays wrap to new lines)AllowShortBlocksOnASingleLine,AllowShortCaseLabelsOnASingleLine, etc. for other block-related formatting
Please verify what formatting behavior you're trying to achieve and use the appropriate valid clang-format option.
| BreakArrays: true |
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5179 +/- ##
=======================================
Coverage 81.95% 81.95%
=======================================
Files 714 714
Lines 73434 73441 +7
Branches 3616 3616
=======================================
+ Hits 60180 60188 +8
Misses 12091 12091
+ Partials 1163 1162 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.