[MSD-653][feat] driver tmcm: add support for 6214#3482
Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial recognition of the TMCM-6214 controller (described as similar to TMCM-3214, with more axes) so it can be handled by existing TMCM tooling and axis-count logic.
Changes:
- Extend
tmcmconfig’s per-model “missing parameter” lists to include model6214. - Add model
6214to the TMCM driver’sKNOWN_MODELSset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
util/tmcmconfig |
Adds TMCM-6214 to per-model missing axis/global parameter maps used when reading/writing configs. |
src/odemis/driver/tmcm.py |
Registers TMCM-6214 as a known model so code paths relying on known model IDs can recognize it. |
| MISSING_AXIS_PARAMS = { | ||
| 1211: {149, 153, 154, 200}, | ||
| 3214: {149, 153, 154, 200}, | ||
| 6214: {149, 153, 154, 200}, | ||
| 1140: {17, 24, 25, 26, 31, 251}, |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds support for the TMCM-6214 controller model to the Odemis driver and configuration system. The driver's 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Similar to 3214, but with more axes.
2e7c522 to
db1075b
Compare
Similar to 3214, but with more axes.
Completely untested, only based on the documentation. => do not merge before testing on the real hardware!