Skip to content

[MSD-653][feat] driver tmcm: add support for 6214#3482

Draft
pieleric wants to merge 1 commit into
delmic:masterfrom
pieleric:feat-driver-tmcm-add-support-for-6214
Draft

[MSD-653][feat] driver tmcm: add support for 6214#3482
pieleric wants to merge 1 commit into
delmic:masterfrom
pieleric:feat-driver-tmcm-add-support-for-6214

Conversation

@pieleric

@pieleric pieleric commented Jun 7, 2026

Copy link
Copy Markdown
Member

Similar to 3214, but with more axes.
Completely untested, only based on the documentation. => do not merge before testing on the real hardware!

Copilot AI review requested due to automatic review settings June 7, 2026 14:43
@github-actions github-actions Bot added the size/S label Jun 7, 2026
@pieleric pieleric changed the title [feat] driver tmcm: add support for 6214 [MSD-653][feat] driver tmcm: add support for 6214 Jun 7, 2026
@pieleric pieleric marked this pull request as draft June 7, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial recognition of the TMCM-6214 controller (described as similar to TMCM-3214, with more axes) so it can be handled by existing TMCM tooling and axis-count logic.

Changes:

  • Extend tmcmconfig’s per-model “missing parameter” lists to include model 6214.
  • Add model 6214 to the TMCM driver’s KNOWN_MODELS set.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
util/tmcmconfig Adds TMCM-6214 to per-model missing axis/global parameter maps used when reading/writing configs.
src/odemis/driver/tmcm.py Registers TMCM-6214 as a known model so code paths relying on known model IDs can recognize it.

Comment thread util/tmcmconfig
Comment on lines 108 to 112
MISSING_AXIS_PARAMS = {
1211: {149, 153, 154, 200},
3214: {149, 153, 154, 200},
6214: {149, 153, 154, 200},
1140: {17, 24, 25, 26, 31, 251},
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 578a4b35-e5f4-4dc8-82b6-f505dad27e1a

📥 Commits

Reviewing files that changed from the base of the PR and between 2e7c522 and db1075b.

📒 Files selected for processing (2)
  • src/odemis/driver/tmcm.py
  • util/tmcmconfig
✅ Files skipped from review due to trivial changes (1)
  • src/odemis/driver/tmcm.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • util/tmcmconfig

📝 Walkthrough

Walkthrough

This PR adds support for the TMCM-6214 controller model to the Odemis driver and configuration system. The driver's KNOWN_MODELS set is updated to recognize the new model during initialization. The configuration utility defines the specific axis parameters (149, 153, 154, 200) and global parameter pairs ((0, 79), (0, 90)) that are unavailable on this controller variant, and adds the model to NO_AXIS_STORAGE.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding support for TMCM-6214 model to the driver, which aligns with the changeset that updates KNOWN_MODELS and configuration tables.
Description check ✅ Passed The description is related to the changeset, explaining that this adds TMCM-6214 support similar to the 3214 model, and includes a clear testing caveat.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Similar to 3214, but with more axes.
@pieleric pieleric force-pushed the feat-driver-tmcm-add-support-for-6214 branch from 2e7c522 to db1075b Compare June 9, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants