Skip to content

Claude/fix edf tariff issues vx lb p#48

Open
gonzague wants to merge 2 commits intodelphiki:mainfrom
gonzague:claude/fix-edf-tariff-issues-vxLbP
Open

Claude/fix edf tariff issues vx lb p#48
gonzague wants to merge 2 commits intodelphiki:mainfrom
gonzague:claude/fix-edf-tariff-issues-vxLbP

Conversation

@gonzague
Copy link
Copy Markdown

No description provided.

This commit incorporates fixes from various issues and pull requests:

Fixes:
- delphiki#37: Bootstrap timeout errors - migrated from requests to aiohttp async
- delphiki#34/delphiki#35: Wrong tariffs - added date validation to select correct rates
- delphiki#38/delphiki#46: Tempo color unavailable - improved error handling with fallbacks
- delphiki#39: Missing state_class - added SensorStateClass.MEASUREMENT for HA statistics
- delphiki#33: TLS certificate issues - added SSL context with disabled verification

New Features:
- delphiki#36: Added subscription tariff sensors (monthly abonnement costs)
- delphiki#41: Added off-peak hours sensor (is_off_peak indicator)
- Improved unique_id generation to prevent conflicts
- Better logging (debug instead of info for routine messages)

Technical Changes:
- Replaced synchronous requests with async aiohttp
- CSV parsing now uses DictReader for named column access
- Proper date range validation for tariff selection
- Graceful degradation when APIs fail
- Version bumped to 3.0.0
divers33 added a commit to divers33/hass-tarif-edf that referenced this pull request Dec 30, 2025
Copy link
Copy Markdown

@Fgdou Fgdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this change does not bring any changes
Furthermore, there is no description, and no tests

"aiohttp>=3.8.0",
"async_timeout>=4.0.0"
],
"version": "3.0.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 3.0.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants