[Spark] Add vacuum command metrics #5787
Open
+74
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Which Delta project/connector is this regarding? - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Add metrics for the vacuum command. Refactors `VacuumCommand` to expose metrics for: - numFilesToDelete - sizeOfDataToDelete - numDeletedFiles - numVacuumedDirectories - status https: //screenshot.googleplex.com/5X3HgSXUEJ33F2L.png ## How was this patch tested? Existing UTs. Ignored flaky test "parallel file delete" in DeltaVacuumSuite. ## Does this PR introduce _any_ user-facing changes? No Change-Id: Icbf47d080ca52127d8058ebcd3f5efc6e462ef7b
#### Which Delta project/connector is this regarding? - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Adds a unit test to verify that vacuum command metrics are correctly reported. ## How was this patch tested? New UT `verify vacuum command metrics` in `DeltaVacuumSuite`. ## Does this PR introduce _any_ user-facing changes? No Change-Id: I268885e4040c5388c3870fa20ba8490dbe60895b
warrenzhu25
force-pushed
the
vacum-metric-of
branch
from
8e8d02f to
0c3371c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add metrics for the vacuum command.
Refactors
VacuumCommandto expose metrics for:Also adds a unit test to verify these metrics.
How was this patch tested?
Existing UTs.
Ignored flaky test "parallel file delete" in DeltaVacuumSuite.
New UT
verify vacuum command metricsinDeltaVacuumSuite.Does this PR introduce any user-facing changes?
No