fix(aria-prohibited-attr): allow aria-label/labelledby on form - #5254
Closed
chutchins25 wants to merge 1 commit into
Closed
fix(aria-prohibited-attr): allow aria-label/labelledby on form#5254chutchins25 wants to merge 1 commit into
chutchins25 wants to merge 1 commit into
Conversation
An unnamed form resolves to a null role but is still allowed global aria-* attributes per ARIA in HTML. Add form to the elementsAllowedAriaLabel option so an empty aria-label/aria-labelledby is no longer prohibited. Closes #5244 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the #5185 fix to the
formelement, which has the same false positive.What & why
Follow-up to #5244 / #5185. An unnamed
<form>resolves to anullrole in axe (implicit-html-roles.js:hasAccessibleName(vNode) ? 'form' : null), soaria-prohibited-attrwrongly prohibitedaria-label/aria-labelledbyon<form aria-labelledby="…">with an empty/unresolved reference.Per ARIA in HTML (
#el-form): the form element allows Globalaria-*attributes, and "Aformis not exposed as a landmark region unless it has been provided an accessible name."Audit result
I audited
implicit-html-roles.jsfor the name-dependent-null-role pattern. Onlysection,aside(fixed in #5185) andformmatch.header/footermap tonullbased on ancestor (not accessible name), and a scoped<footer>/<header>is exposed asgeneric— which prohibits naming — so flagging those is correct and they are intentionally excluded.Fix
Add
formto theelementsAllowedAriaLabeloption (named forms already pass via theformlandmark role).Tests
aria-prohibited-attrcheck unit — form with emptyaria-labelledby; named form.aria-prohibited-attrintegration — form with emptyaria-labelledbypass case.doc/check-options.mddefault updated.Closes #5244