Skip to content

refactor(aria): share the none role definition with presentation #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straker merged 3 commits into from
Aug 3, 2026
+10 −6
Merged

refactor(aria): share the none role definition with presentation #5255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b13d753
refactor(aria): share the none role definition with presentation
chutchins25 Jul 29, 2026
ee19e80
Merge branch 'develop' into chut/5249-none-presentation-synonym
straker Jul 29, 2026
a974f2f
Merge remote-tracking branch 'origin/develop' into chut/5249-none-pre…
chutchins25 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/standards/aria-roles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ const imgRole = {
childrenPresentational: true
};

// Shared definition for the none and presentation roles, so the two entries
// stay in sync.
const noneRole = {
type: 'structure',
superclassRole: ['structure'],
prohibitedAttrs: ['aria-label', 'aria-labelledby']
};

const ariaRoles = {
alert: {
type: 'structure',
Expand Down Expand Up @@ -462,9 +470,7 @@ const ariaRoles = {
superclassRole: ['landmark']
},
none: {
type: 'structure',
superclassRole: ['structure'],
prohibitedAttrs: ['aria-label', 'aria-labelledby']
...noneRole
},
note: {
type: 'structure',
Expand Down Expand Up @@ -495,9 +501,7 @@ const ariaRoles = {
prohibitedAttrs: ['aria-actions', 'aria-label', 'aria-labelledby']
},
presentation: {
type: 'structure',
superclassRole: ['structure'],
prohibitedAttrs: ['aria-label', 'aria-labelledby']
...noneRole
},
Comment thread
chutchins25 marked this conversation as resolved.
progressbar: {
type: 'widget',
Expand Down
Loading