fix: improve plugin shortcut conflict error messages#3881
Open
ikchifo wants to merge 6 commits intoderailed:masterfrom
Open
fix: improve plugin shortcut conflict error messages#3881ikchifo wants to merge 6 commits intoderailed:masterfrom
ikchifo wants to merge 6 commits intoderailed:masterfrom
Conversation
Show the conflicting action's name in error messages and surface the
first error in the flash bar instead of a generic logo warning.
Before:
Log: duplicate plugin key found for "Ctrl-K" in "kubehop"
UI: "Plugins load failed!" (logo bar, no detail)
After:
Log: plugin "kubehop" shortcut "Ctrl-K" conflicts with "Kill"
(use override: true to replace)
UI: Same message in the flash bar (bottom of screen)
Resolves derailed#3880
derailed
requested changes
Mar 15, 2026
Owner
derailed
left a comment
derailed
left a comment
There was a problem hiding this comment.
@ikchifo Thank you for this update!
I think we might need a better solution for this as it will only report one issue at a time and in the flash which is less than ideal in case of hoarked cut/paste.
Perhaps an error view might be a better semantic for this?
Also it looks like the linter is not happy ;(
internal/view/actions.go
Outdated
|
|
||
| // firstError extracts the first error from a joined error chain. | ||
| func firstError(err error) error { | ||
| if err == nil { |
Owner
There was a problem hiding this comment.
I think this check is superfluous as the type check below would fail otherwise
derailed
added
enhancement
Author
|
@derailed Thanks for taking a look. |
Replace ephemeral flash message (showing only the first error) with a dismissable error dialog that displays all conflicts at once. Uses an atomic guard following the firstView pattern to prevent the dialog from re-appearing on every refresh cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3880
Plugin shortcut conflicts now show what they conflict with and how to fix it, in the flash bar instead of a generic logo warning.
Before:
After:
Changes
internal/view/actions.go: Include conflicting action name andoverride: truehint in errorinternal/view/browser.go: Show first error in flash bar instead of generic logo warning