feat(governance): New LoadCanisterSnapshot proposal type. #8317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This is analogous to the changes in PR 8158.
…logous to the changes in PR 8159.
This is analogous to changes made in commit cbd88f0, but here, we do not add a new NnsFunction; but rather, we add directly to Action. Why direct Action instead of NnsFunction: The Governance canister cannot treat the arguments of LoadCanisterSnapshot as an opaque blob. In particular, Governance needs to know which canister is being restored in order to determine the proposal's topic, like for canister upgrades.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
Disabled by flag.
jasonz-dfinity
approved these changes
Jan 12, 2026
…pt blob;`, rs/nns/governance/api/src/types.rs should say `snapshot_id: Option<Vec<u8>>,`. Without this, interface test fails.
Conflicts: - rs/nns/governance/src/pb/conversions/mod.rs :: Conflict seems to arrise from the fact that in master, some code was deleted right next to where I added some code. `git diff --cached master` seems to indicate that I preserved my addition while also preserving the deletion in master.
…that: pb_api -> api.
Base automatically changed from
test-action-based-take-snapshot-daniel-wong
to
master
January 13, 2026 11:10
Conflicts occurred due to changes being added to master via a squash commit. IIUC, `git merge -X ours master` would have resolved the conflicts in the same way that I just did.
daniel-wong-dfinity-org
deleted the
action-based-load-snapshot-daniel-wong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with TakeCanisterSnapshot, this works by calling a new method on the Root canister: load_canister_snapshot.
Future Work
Snapshot operations should should generally be performed while the canister is stopped (like with upgrades). The reason for this is explained in the ICP specification:
References
Closes NNS1-4297.