Skip to content

Conversation

@marc0olo
Copy link
Member

I noticed that we have a problem with displaying the changes correctly for each recipe on releases and vibed a bit with Claude to fix it.

should work for all recipes.

image

@marc0olo marc0olo requested a review from a team as a code owner January 20, 2026 16:34
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Update latest tag
Copy link
Collaborator

@raymondk raymondk Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is automatically pushing a $RECIPE-latest tag
When the tag is pushed doesn't that throw off the pipeline for latest because it is going to compare to whatever the highest version tag is (which will likely be the same) and not generate the proper release notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure what your concern is, so let me address both possibilities:

  1. if you're worried about the -latest release having empty/wrong release notes:

    • you're right - the original code would compare rust-v5.0.0..rust-latest which are the same commit, resulting in empty release notes.
    • I fixed this now by finding the versioned tag on the same commit (rust-v5.0.0), then comparing against its predecessor (rust-v4.0.0..rust-v5.0.0). now both releases should get the same correct release notes.
  2. if you're worried about -latest tags interfering with versioned releases:

    • this should already be safe - the previous tag search uses the pattern ${RECIPE}-v*, which only matches versioned tags like rust-v5.0.0 and never matches rust-latest.

these are the scenarios that should be covered now:

Scenario PREV_TAG COMPARE_TAG Result
1. Push rust-v4.0.0 rust-v3.0.0 rust-v4.0.0 Changelog ✓
2. rust-latest triggered (same commit as rust-v4.0.0) rust-v3.0.0 rust-v4.0.0 Changelog ✓
3. Push newrecipe-v1.0.0 (first ever version) (empty) newrecipe-v1.0.0 Initial release ✓
4. newrecipe-latest triggered (same commit as v1.0.0) (empty) newrecipe-v1.0.0 Initial release ✓
5. Push newrecipe-latest without versioned tag - - Fails ✓

let me know if you had a different concern in mind.

@marc0olo marc0olo enabled auto-merge (squash) January 22, 2026 17:46
@marc0olo marc0olo merged commit d408a2a into main Jan 22, 2026
5 checks passed
@marc0olo marc0olo deleted the marc0olo/improve-release-notes-process branch January 22, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants