Conversation
Co-authored-by: dictcp <1752436+dictcp@users.noreply.github.com>
Co-authored-by: dictcp <1752436+dictcp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create local pull request based on PR 640
Add Mar 4, 2026
--match-relative-path duplicate filter and document ASCII-only case matching semantics
dictcp
reviewed
Mar 4, 2026
dictcp
reviewed
Mar 4, 2026
Co-authored-by: dictcp <1752436+dictcp@users.noreply.github.com>
dictcp
reviewed
Mar 4, 2026
Co-authored-by: dictcp <1752436+dictcp@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a new duplicate-filtering mode, --match-relative-path, to restrict duplicate detection to files that share the same relative path across scanned roots, and updates the manpage to clarify the ASCII-only case-insensitive matching semantics used by these comparisons.
Changes:
- Add
--match-relative-pathCLI flag and config plumbing. - Implement relative-path comparison (
rm_file_relpaths_cmp) and integrate it into file grouping/comparison. - Add pytest coverage for relative-path matching and document ASCII-only case-insensitive behavior in the manpage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_options/test_match_relative_path.py | Adds option-level tests for positive/negative relative-path matching scenarios. |
| lib/preprocess.c | Applies match_relative_path (and fixes early-return behavior for match_without_extension) during file comparison/grouping. |
| lib/file.h | Declares the new relative-path comparison helper. |
| lib/file.c | Implements rm_file_relpaths_cmp by comparing trie nodes up to the file’s traversal depth. |
| lib/cmdline.c | Registers the new --match-relative-path command-line option. |
| lib/cfg.h | Adds match_relative_path to runtime configuration. |
| docs/rmlint.1.rst | Documents the new flag and clarifies ASCII-only case-insensitive matching semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: dictcp <1752436+dictcp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--match-relative-pathwith explicit file inputs of different basenamesglib-2.0 >= 2.64)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.