Skip to content

Add ForeignExample for OpenJPA#728

Draft
eolivelli wants to merge 9 commits intomasterfrom
fix/add-foreign-key-example
Draft

Add ForeignExample for OpenJPA#728
eolivelli wants to merge 9 commits intomasterfrom
fix/add-foreign-key-example

Conversation

@eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Oct 28, 2020 •
edited
Loading

Follow up of #732

  • upgrade OpenJPA to 3.1.3
  • enable "native" SchemaFactory, that create FOREIGN KEYs at database level
  • add test cases

@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 29, 2020

This is a draft as it depends on snapshot version of OpenJPA

eolivelli
eolivelli commented Oct 31, 2020
View reviewed changes
herddb-thirdparty/openjpa-test/pom.xml
<groupId>org.apache.openjpa</groupId>
<artifactId>openjpa</artifactId>
<version>3.1.1</version>
<version>3.1.3-SNAPSHOT</version>
Copy link
Contributor Author

@eolivelli eolivelli Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be seen a problematic for a release, but it is needed in order to see the test work.
if we want to cut a release we must revert back to 3.1.2 and comment parts of the test
I hope that with @rmannibucau 's help we could release OpenJPA 3.1.3 soon

eolivelli
eolivelli commented Oct 31, 2020
View reviewed changes
herddb-thirdparty/openjpa/src/main/java/herddb/openjpa/DBDictionary.java
supportsForeignKeys = false;
supportsUniqueConstraints = false;
supportsCascadeDeleteAction = false;
supportsDeferredConstraints = false;
Copy link
Contributor Author

@eolivelli eolivelli Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same change did on OpenJPA 3.1.3-SNAPSHOT on "official" HerdDB dictionary

@eolivelli eolivelli requested a review from diegosalvi October 31, 2020 15:42
@eolivelli eolivelli marked this pull request as ready for review October 31, 2020 15:42
@eolivelli eolivelli changed the title Add OpenJPA foreignkey example Fix JDBC Metadata for FKs, fix delimiters for FKs and add more tests about OpenJPA Nov 2, 2020
@eolivelli
Copy link
Contributor Author

eolivelli commented Nov 2, 2020

For reference this is the bug on OpenJPA
https://issues.apache.org/jira/browse/OPENJPA-2837

I will work on it this week
cc @rmannibucau

@eolivelli eolivelli force-pushed the fix/add-foreign-key-example branch from 6134cf1 to ebf6348 Compare November 10, 2020 07:58
@eolivelli
Copy link
Contributor Author

eolivelli commented Nov 12, 2020

We have to wait for OpenJPA 3.1.3
I have filed this PR with the first part of the fix, without the OpenJPA 3.1.3 upgrade with support for FKs

@eolivelli eolivelli changed the title Fix JDBC Metadata for FKs, fix delimiters for FKs and add more tests about OpenJPA Add ForeignExample for OpenJPA Nov 13, 2020
@eolivelli eolivelli marked this pull request as draft November 13, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegosalvi diegosalvi Awaiting requested review from diegosalvi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eolivelli