Defer dependency resolution using LazyFiles#2724
Closed
simonlebras wants to merge 3 commits intodiffplug:mainfrom
Closed
Defer dependency resolution using LazyFiles#2724simonlebras wants to merge 3 commits intodiffplug:mainfrom
simonlebras wants to merge 3 commits intodiffplug:mainfrom
Conversation
simonlebras
force-pushed
the
lazy-config
branch
from
5a42987 to
3a6d83a
Compare
simonlebras
force-pushed
the
lazy-config
branch
from
d7d13e2 to
a5a7fb6
Compare
Member
|
This PR might be necessary, but I'm not sure yet. We can stack the laziness to infinity Spotless is supposed to not configure if it isn't on the task graph. I suppose that broke at some point, and I think #2719 fixes that. Have you done any local integration testing which shows that this PR provides further perfomance improvements if Spotless is not being executed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Gradle lazy APIs to defer configuration resolution.
Provisioner cannot depend on Gradle APIs so I've created a wrapper for getting config files lazily