Skip to content

fix: enforce pathLenConstraint regardless of keyUsage extension #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddieran wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

fix: enforce pathLenConstraint regardless of keyUsage extension #1142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/x509.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3186,10 +3186,9 @@ pki.verifyCertificateChain = function(caStore, chain, options) {
error: pki.certificateError.bad_certificate
};
}
// if error is not null and keyUsage is available, then we know it
// has keyCertSign and there is a basic constraints extension too,
// which means we can check pathLenConstraint (if it exists)
if(error === null && keyUsageExt !== null &&
// check pathLenConstraint (if it exists) regardless of whether
// keyUsage extension is present
if(error === null && bcExt !== null &&
'pathLenConstraint' in bcExt) {
// pathLen is the maximum # of intermediate CA certs that can be
// found between the current certificate and the end-entity (depth 0)
Expand Down