Fix timeout when deleting a language with many translations #4084
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When deleting a language, all translations (pages, events, POIs) with that language get cascade-deleted. For each deletion, the linkcheck library's pre_delete signal fires and calls get_absolute_url(). With thousands of translations, this causes a timeout before the DELETE query reaches the database. Evidence: - region_actions.py already uses disable_listeners() when deleting regions - The comment there states: "Active linkchecking would drastically slow performance" - language_tree_actions.py was missing this pattern Solution: Wrap language_node.delete() with disable_listeners() - the same pattern already used for region deletion. Fixes #3997 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
svenseeberg
reviewed
Jan 17, 2026
| # When a language is deleted, all translations (pages, events, POIs) are cascade-deleted. | ||
| # For each deletion, linkcheck's pre_delete signal calls get_absolute_url(). | ||
| # With many translations, this causes a timeout before the DELETE query reaches the database. | ||
| # This pattern is also used in region_actions.py for the same reason. |
Member
There was a problem hiding this comment.
The comment should be removed.
Removing linkcheck listeners disabled, the links would AFAICT not be deleted. That means we potentially keep outdated links in the database. That means we need to clean up these as well.
Collaborator
Author
There was a problem hiding this comment.
Done! Simplified the comment.
Regarding the orphaned links: The findlinks management command will clean them up on its next run. This is the same pattern used in region_actions.py for region deletion.
The linkcheck data model separates Url (the actual URL string) from Link (the relationship to a content object). When translations are deleted:
- Only the
Linkrecords become orphaned Urlrecords stay intact (may still be used by other regions)findlinksdeletes orphanedLinkrecords and only removesUrlrecords if noLinkreferences them
So other regions' links are unaffected by this cleanup.
- Shortened the verbose comment as requested - Clarified that orphaned links will be cleaned up by findlinks command - This is consistent with the pattern used in region_actions.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Internal Server Error that occurs when deleting a language with many translations.
Problem
When deleting a language, all translations (pages, events, POIs) with that language get cascade-deleted. For each deletion, the linkcheck library's
pre_deletesignal fires and callsget_absolute_url(). With thousands of translations, this causes a timeout before the DELETE query reaches the database.Evidence
region_actions.pyalready usesdisable_listeners()when deleting regionslanguage_tree_actions.pywas missing this patternSolution
Wrap
language_node.delete()withdisable_listeners()- the same pattern already used for region deletion.Test plan
Fixes #3997
🤖 Generated with Claude Code