feat: add options object to specify custom params for feed.items()#1264
Open
Androz2091 wants to merge 7 commits intodilame:masterfrom
Open
feat: add options object to specify custom params for feed.items()#1264Androz2091 wants to merge 7 commits intodilame:masterfrom
Androz2091 wants to merge 7 commits intodilame:masterfrom
Conversation
Author
|
Could close #1263 |
Nerixyz
requested changes
Aug 27, 2020
Collaborator
Nerixyz
left a comment
Nerixyz
left a comment
There was a problem hiding this comment.
You should use the class as the input for the options not the request method.
Author
|
I tried to change that, should we add |
Nerixyz
requested changes
Aug 27, 2020
Contributor
Collaborator
dilame
reviewed
Sep 11, 2020
| @Expose() | ||
| private seqId: number; | ||
|
|
||
| public limit?: number; |
Owner
There was a problem hiding this comment.
Specify the default values here instead of using ?? operator below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now possible to retrieve as many messages as desired per thread when fetching direct inbox items or direct thread items