Expose opus_decode's support for FEC and PLC through a new JS conceal method.#197
Open
JonathanLennox wants to merge 1 commit intodiscordjs:mainfrom
Open
Expose opus_decode's support for FEC and PLC through a new JS conceal method.#197JonathanLennox wants to merge 1 commit intodiscordjs:mainfrom
JonathanLennox wants to merge 1 commit intodiscordjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This code exposes Opus's FEC and PLC support in discord/opus.
If the Opus data being decoded passed over an unreliable channel (e.g. WebRTC) at some point, packets may be missing. FEC and PLC allow missing audio to be interpolated.
This code has been written to be backward-compatible, so existing usages won't need to change.
This is a different API approach than #195 to implement the feature request in #196. It separates the loss concealment functionality into a new API, which should be somewhat less confusing and harder to mis-use than the approach in #195.