Skip to content

Add CancelWithErr mechanism#11

Open
neilotoole wants to merge 1 commit intodjherbis:masterfrom
neilotoole:cancel-with-err
Open

Add CancelWithErr mechanism#11
neilotoole wants to merge 1 commit intodjherbis:masterfrom
neilotoole:cancel-with-err

Conversation

@neilotoole
Copy link
Copy Markdown

We already have a Stream.ShutdownWithErr mechanism, which propagates a custom error.

There's also a Stream.Cancel method. However, there should be a Stream.CancelWithErr method to allow propagation of a custom error.

For example, let's say I'm reading from an http response, and writing the bytes to a stream. If there's an error reading the response, I specifically want to Cancel the stream (as opposed to calling Shutdown). But, any clients of the stream will just receive a generic ErrCanceled, which is not super helpful. I want to be able to propagate the http error back to the stream clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant