[delta] add a Recursive type arg, avoiding excessive instantiation
#98
+46
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is that instead of having a whole RecursiveDelta type, add a type arg to a Delta (Recursive=boolean) which can be used to check whether a delta is recursive or not, and then typecheck based on that flag instead of having to construct the whole type. TS doesn't do well with recursive types, since technically this is infinite. It's better to have it check constraints rather than have to build out whole type trees
This code was failing to type-check before:
And, now it can, since we don't use the RecursiveDelta anymore