Wire the Console EntityValueResolver as a service#2193
Open
chalasr wants to merge 1 commit intodoctrine:2.18.xfrom
Open
Wire the Console EntityValueResolver as a service#2193chalasr wants to merge 1 commit intodoctrine:2.18.xfrom
chalasr wants to merge 1 commit intodoctrine:2.18.xfrom
Conversation
chalasr
force-pushed
the
console-entity-resolver
branch
7 times, most recently
from
0c55ab2 to
13ab18d
Compare
chalasr
force-pushed
the
console-entity-resolver
branch
from
13ab18d to
bc88352
Compare
Contributor
Author
|
The Symfony PR has been merged so this PR is ready. |
stof
reviewed
Feb 5, 2026
| $this->assertEquals(new MapEntity(null, null, null, [], null, null, null, true, true), $container->get('controller_resolver_defaults')); | ||
| } | ||
|
|
||
| #[IgnoreDeprecations] |
Member
There was a problem hiding this comment.
Why ignoring deprecations ? This test is meant to cover a new feature, not a deprecated feature. It has no reason to ignore deprecations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the EntityValueResolver for Console commands that has been introduced in symfony/symfony#62917.
Needs symfony/symfony#62917 to be merged first✅Please let me know if I missed anything.