Skip to content

RPGrpScreen matched but not linked + RPGrpTexture progress#133

Merged
kiwi515 merged 1 commit into
doldecomp:masterfrom
ThePlayerRolo:master
Apr 18, 2026
Merged

RPGrpScreen matched but not linked + RPGrpTexture progress#133
kiwi515 merged 1 commit into
doldecomp:masterfrom
ThePlayerRolo:master

Conversation

@ThePlayerRolo
Copy link
Copy Markdown
Contributor

I tried to link RPGrpScreen but I got errors about gap symbols being missing from other TU's

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Apr 18, 2026

Report for RSPE01_01 (9384c77 - 18e9bfb)

📈 Matched code: 32.63% (+0.02%, +704 bytes)
📈 Matched data: 37.50% (+0.00%, +4 bytes)

✅ 9 new matches
Unit Item Bytes Before After
main/Pack/RPGraphics/RPGrpScreen RPGrpScreen::DrawQuadTexture(float, float, float, float, EGG::ResTIMG*, _GXColor) +244 0.00% 100.00%
main/Pack/RPGraphics/RPGrpTexture RPGrpTexture::RPGrpTexture(unsigned short, const char*) +128 0.00% 100.00%
main/Pack/RPGraphics/RPGrpScreen RPGrpScreen::DrawQuad(float, float, float, float, _GXColor) +112 0.00% 100.00%
main/Pack/RPGraphics/RPGrpScreen __sinit_\RPGrpScreen_cpp +92 0.00% 100.00%
main/Pack/RPGraphics/RPGrpTexture RPGrpTexture::RPGrpTexture(const EGG::ResTIMG*) +60 0.00% 100.00%
main/Pack/RPGraphics/RPGrpScreen RPGrpScreen::BeginDrawQuad() const +28 0.00% 100.00%
main/Pack/RPGraphics/RPGrpScreen RPGrpScreen::BeginDrawQuadTexture(bool) const +28 0.00% 100.00%
main/Pack/RPGraphics/RPGrpScreen RPGrpScreen::Initialize(const unsigned short*, const unsigned short*) +12 0.00% 100.00%
main/Pack/RPGraphics/RPGrpScreen .ctors +4 0.00% 100.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
main/Pack/RPGraphics/RPGrpScreen .bss +103 0.00% 86.67%
main/Pack/RPGraphics/RPGrpTexture .data +14 0.00% 88.57%
main/Pack/RPGraphics/RPGrpScreen .sdata2 +4 0.00% 50.00%

@kiwi515
Copy link
Copy Markdown
Collaborator

kiwi515 commented Apr 18, 2026

thank u for the contribution!! i have some RPGraphics work on my fork, so i'll look into fixing the link issues :D

@kiwi515 kiwi515 merged commit e29a314 into doldecomp:master Apr 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants