Add missing license#30
Conversation
|
Hi, First and foremost, sorry for getting to this PR later than I would have liked to. Secondly, I'd like to thank you for bringing to my attention the issues outlined in this PR. I have provided my thoughts on the issues raised. Logo I fully agree the logo is very similar. As such, the current logo for this project will be changed. ReadMe A revamp of the ReadMe has been planned for quite some time. Adjusts will be made to sections that are too similar to the mentioned project. Name A quick Google search leads to numerous open-source projects and websites with either a similar or identical name, most of which were created before the project you mentioned. Therefore, stating the mentioned project as the original project would be disingenuous to the others that came before it. I would feel more comfortable and think it would be best to give credit in general perspective to the similarly named projects instead of just a single one. I'm open to any suggestions you may have. |
|
Hello, I don't think the issue here is the similarity; the mentioned project was just clearly used as a base for yours, which is totally fine, because it's license allows it. but it is also the reason why it should be credited. Changing the Readme to make it different doesn't cancel the fact that it is still a "derivative work", as stated in the original license. The same thing applies to the logo. I agree the name of the project is used by many others people. The point is not to associate ownership of the name to a specific project. |
domsec
left a comment
domsec
left a comment
There was a problem hiding this comment.
After considering your comments, I believe my suggested modifications provide a more comprehensive and accurate credit to the original project.
Since it has been some time since our last conversation in this PR (apologies for such a length of time), I will plan to push these changes myself after 2 weeks if such modifications are not pushed.
|
|
||
| ### Original project | ||
|
|
||
| - [johansatge/jpeg-autorotate](https://github.com/johansatge/jpeg-autorotate) |
There was a problem hiding this comment.
I think it would be best to clearly state where the inspiration for this library originated from and the elements that are either the same, similar, or modified from the original project, as mentioned in your comments.
| - [johansatge/jpeg-autorotate](https://github.com/johansatge/jpeg-autorotate) | |
| The inspiration for this library (including the name and logo) originated from [johansatge/jpeg-autorotate](https://github.com/johansatge/jpeg-autorotate), available under the [MIT License](https://github.com/johansatge/jpeg-autorotate/blob/master/license.md). Additionally, portions of the README file (including the project description and features) are derived from this project, but with some modifications. |
| - Stroke width decreased for all icons by 0.25 | ||
| - Detached arrows from [sync-alt](https://fontawesome.com/icons/sync-alt?style=solid) | ||
|
|
||
| ### Original project |
There was a problem hiding this comment.
I think it would be best to place this subsection first, before the Libraries subsection.
2 participants
Hello,
thank you for publishing open-source work on GitHub!
It seems your project is missing some licensing information.
The readme, logo, and project name have been copied from johansatge/jpeg-autorotate, which is fine, because its MIT license allows derivative work. But in order to respect said license, you also need to credit the original project; hence, this pull request.
(It may not be obvious, but the name of a project, its readme, and all other assets are part of it, and are covered by its license. A license does not only cover the source code of a project!)
Thank you and have a nice day!