Skip to content

Conversation

@Millertaker
Copy link

@Millertaker Millertaker commented Jan 15, 2026

Proposed Changes

  • Fixed HTML Page URL being incorrectly overwritten by the Content Type's defaultValue during workflow actions (e.g., Publish)
  • Added logic in ESContentletAPIImpl.find() to populate the URL from identifier.asset_name when the URL field has a defaultValue defined in the Content Type
  • Added integration test test_find_HTMLPage_URL_ShouldBePopulatedFromIdentifier to verify the fix

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

Issue: Fixes #33893

Root Cause: For HTML Pages, the URL is stored in identifier.asset_name, not in the contentlet table (text3 column is empty). When loading an HTML Page contentlet via find(), if the URL field in the Content Type has a defaultValue defined (e.g., "test"), that default value was being applied instead of the actual URL from the identifier. This caused the Publish button on the Page Edit screen to overwrite the user-typed URL with the default value.

Fix Location: ESContentletAPIImpl.find() (lines 441-454)

Behavior:

  • Only applies to HTML Page contentlets
  • Only triggers when the URL field has a defaultValue defined in the Content Type
  • Retrieves the correct URL from identifier.asset_name and sets it on the contentlet

Screenshots

Screen.Recording.2026-01-15.at.11.28.15.AM.mov

@Millertaker Millertaker force-pushed the issue-33893-fix-publish-button branch from 2d5f9a2 to 939c1e3 Compare January 16, 2026 19:52
Copy link
Contributor

@dsilvam dsilvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this until further questions from @nathan-hildebrandt are answered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[DEFECT] Publish button on Page edit screen holds on to default value when another value was typed in.

5 participants