🪲 BUG-#246: Run background cleanup regardless of config#296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified files:
dotflow/core/workflow.py— Changedelif self.config:toelse:inManager.__init__. The cleanup thread that joins the background worker and fireson_success/on_failurecallbacks is now always started whenmode=BACKGROUND, regardless of whetherconfigis provided.tests/core/test_workflow.py— Added two new tests covering the fixed scenario:test_background_callback_runs_without_configandtest_background_callback_failure_runs_without_config.Motivation and Context
When running in
BACKGROUNDmode without aconfigobject (config=None), the original conditional chain fell through both branches — neither_callback_workflownor the cleanup thread was ever started. This silently swallowedon_successandon_failurecallbacks entirely.Closes #246
Type of change
Checklist